Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Hiera compatibility #905

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 6, 2023

This does the required includes for apache and postgresql::server if needed. It then uses this together with beaker-hiera (which voxpupuli-acceptance already automatically sets up for us) to reduce duplication in acceptance tests.

ekohl added 2 commits November 6, 2023 23:16
This is safe to do because it can be called even after an explicit class
statement. The following code is legal.

    class { 'postgresql::server':
    }
    include postgresql::server

It could make a difference for a remote database, but due to the usage
of postgresql::server::pg_hba_rule that was already invalid.

The explicit require is also not needed, since postgresql::server::db
already does this where needed.

The end result is that the module is easier to use.
This is similar to the inclusion of postgresql::server if needed.
@ekohl
Copy link
Member Author

ekohl commented Nov 6, 2023

Needs voxpupuli/voxpupuli-acceptance#77 for Puppet 8.

ekohl added 2 commits November 6, 2023 23:59
By using beaker-hiera there is no need to provide it in every acceptance
test.
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am not sure about the extra parameters that where passed to postgresql::globals (but the tests seems to prove that they are not required), and including the required code is IMHO the right thing to do!

@evgeni evgeni added the enhancement New feature or request label Nov 7, 2023
@evgeni evgeni merged commit e4c1c29 into voxpupuli:master Nov 7, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants